[Yaffs] Kernel panic in clear_inode when using yaffs as rootfs
Charles Manning
Charles.Manning at trimble.co.nz
Mon Nov 14 02:46:35 GMT 2005
Thanx Andre
FYI: How this got broken: http://lwn.net/Articles/141982/
Makes it easy for OCFS2, breaks YAFFS.
> -----Original Message-----
> From: Andre Renaud [mailto:andre at bluewatersys.com]
> Sent: Monday, 14 November 2005 3:24 p.m.
> To: Charles Manning
> Cc: yaffs at stoneboat.aleph1.co.uk; manningc2 at actrix.gen.nz
> Subject: Re: [Yaffs] Kernel panic in clear_inode when using
> yaffs as rootfs
>
> Charles Manning wrote:
> > Is this only with yaffs as root or will stress also break non-root?
>
> I think I found it, according to fs/inode.c:1039
> if (op->delete_inode) {
> void (*delete)(struct inode *) = op->delete_inode;
> if (!is_bad_inode(inode))
> DQUOT_INIT(inode);
> /* Filesystems implementing their own
> * s_op->delete_inode are required to call
> * truncate_inode_pages and clear_inode()
> * internally */
> delete(inode);
> } else {
> truncate_inode_pages(&inode->i_data, 0);
> clear_inode(inode);
> }
>
> However, yaffs_delete_inode does not call truncate_inode_pages.
>
> The attached patch seems to resolve it.
>
> Thanks,
> Andre
>
> --
> Bluewater Systems Ltd - ARM Technology Solutions Centre
>
> Andre Renaud Bluewater Systems Ltd
> Phone: +64 3 3779127 (Aus 1 800 148 751) Level 17, 119
> Armagh St
> Fax: +64 3 3779135 PO Box 13889
> Email: arenaud at bluewatersys.com Christchurch
> Web: http://www.bluewatersys.com New Zealand
>
More information about the yaffs
mailing list