[Yaffs] yaffs on Linux 2.6.9 - patch 4 of 7

[Frank Rowand]

This is a multi-part message in MIME format.
--------------090906000504000501060502
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


--------------090906000504000501060502
Content-Type: text/plain;
 name="yaffs_kernel_04_disable_no_page_cache.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="yaffs_kernel_04_disable_no_page_cache.patch"

Index: linux-2.6.9/fs/yaffs/yaffs_fs.c
===================================================================
--- linux-2.6.9.orig/fs/yaffs/yaffs_fs.c
+++ linux-2.6.9/fs/yaffs/yaffs_fs.c
@@ -103,6 +103,28 @@
 
 static void yaffs_put_super(struct super_block *sb);
 
+/*
+ * http://www.aleph1.co.uk/pipermail/yaffs/2004q4/000747.html
+ *
+ * from: Charles Manning  Charles.Manning@trimble.co.nz
+ * subject: [Yaffs] CONFIG_YAFFS_USE_GENERIC_RW
+ * date: Thu, 14 Oct 2004 12:12:36 +1300
+ *
+ * The direct read/write stuff was iimplemented first, and I followed it by
+ * generic read/write when memory mapping was implemented. During the
+ * transition both options worked. Things have now moved on and not
+ * defining USE_GENERIC_RW is broken, with no real motivation to fix it.
+ *
+ * Ie. You should always define USE_GENERIC_RW.
+ *
+ * This comes up every couple of months on the list. I guess I should pull
+ * it out.
+ *
+ * -- Charles
+ */
+
+#define CONFIG_YAFFS_USE_GENERIC_RW
+
 #if !defined(CONFIG_YAFFS_USE_GENERIC_RW)
 static ssize_t yaffs_file_read(struct file *f, char *buf, size_t n, loff_t *pos);
 #endif
Index: linux-2.6.9/fs/Kconfig
===================================================================
--- linux-2.6.9.orig/fs/Kconfig
+++ linux-2.6.9/fs/Kconfig
@@ -1437,19 +1437,6 @@
 
 	  If unsure, say N.
 
-config YAFFS_USE_GENERIC_RW
-	bool "Use Linux file caching layer"
-	default y
-	depends on YAFFS_FS
-	help
-	  Use generic_read/generic_write for reading/writing files. This
-	  enables the use of the Linux file caching layer.
-
-	  If you disable this, then caching is disabled and file read/write
-	  is direct.
-
-	  If unsure, say Y.
-
 config YAFFS_USE_HEADER_FILE_SIZE
 	bool "Use object header size"
 	depends on YAFFS_FS

--------------090906000504000501060502--