From Jisheng.Zhang@synaptics.com Thu Apr 23 07:38:11 2020 Received: from mail-mw2nam10on2079.outbound.protection.outlook.com ([40.107.94.79] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by stoneboat.default.lvansomeren.uk0.bigv.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jRVUt-0000Rn-4H for yaffs@stoneboat.aleph1.co.uk; Thu, 23 Apr 2020 07:38:11 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RpUgiEg14shMfpdiKhiXypJGUn3gANsCGeE+o99xbO5lZlA0DSbTyzbNgxAcBBFZ3+JNQitFT2Hlu0yvj/dzbjfPQZ1hrSfJzcgUObfN0fdghiPQYC850V12JqRQiG94sdtyM1PWUnlSVl6o0IeGsXEQ5yNHLA/L8hKQhMM347+CjB3sDA0q/LPzzeGIzfTUNyJcyEy/fj8NMTLaKsWL645OBVrNS3/PoVqL7tqdCR1JmeoN1+NTUMhGHm1TT9nUyggFM+Rmfh/y6mILzvNq+EY+wJQ0WUDu+M7UeeX6IwmwBfmnDCEltoaVSjcvw8wii6TxxsXHZT18Pyw5gUklIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JeKSo3uDFL2w2dCSqYucLDgjlIJbwoUjY6hAJ1W/yVg=; b=ihHt4W8vHiAhqxhmNdlm9kXUiT7bdasA94jsd4avkIuUWJD0DaS9Khalsp1vPCAe/cV/4NXDKbyVtKciuSjymXka6U5RiP7Km7zWI9+bnfqeyI055EDUNFNI/9TaB8Al+1Wr09R5wgYQCN3woe+pP41CjKkFDehsM4dZE2lYWGODkBHK0LTwvEhcvmTM9sTgLL5K3cUNYoBSLyGNMg0X6KHZQbu1gy43hNmSO5Z0LBDMxmwnqNWUTV/wpwPatMMi6IHqs+X3WQhnL31w/TrutrKdp2llF2SKwg/Ix5fPXV4ZXmfxvfxUArLVdX+sXPf3gOgX+lUtpxetANjeyPCzdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synaptics.com; dmarc=pass action=none header.from=synaptics.com; dkim=pass header.d=synaptics.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Synaptics.onmicrosoft.com; s=selector2-Synaptics-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JeKSo3uDFL2w2dCSqYucLDgjlIJbwoUjY6hAJ1W/yVg=; b=bWxxeh5df4jMalZM1oY2efXq800Bu4fO+WYkxcdarKAhZAnQJjpoeevxU+8N+DC5QOLOFUajFpb/HY4iYouRUTETU1sZcjocJLYjkSrdtEnQFd63A8XkTPP73XF+eCY5XEo2PGnGGZDOFvUvf9iPYLp20dGhYioleRtDpdnQOtw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jisheng.Zhang@synaptics.com; Received: from BYAPR03MB3573.namprd03.prod.outlook.com (2603:10b6:a02:ae::15) by BYAPR03MB3591.namprd03.prod.outlook.com (2603:10b6:a02:ac::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Thu, 23 Apr 2020 06:38:02 +0000 Received: from BYAPR03MB3573.namprd03.prod.outlook.com ([fe80::d8fb:de22:43b7:fcb7]) by BYAPR03MB3573.namprd03.prod.outlook.com ([fe80::d8fb:de22:43b7:fcb7%7]) with mapi id 15.20.2937.012; Thu, 23 Apr 2020 06:38:02 +0000 Date: Thu, 23 Apr 2020 14:37:45 +0800 From: Jisheng Zhang To: Charles Manning , yaffs@stoneboat.aleph1.co.uk Message-ID: <20200423143745.24fc6f0c@xhacker.debian> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: TY1PR01CA0205.jpnprd01.prod.outlook.com (2603:1096:403::35) To BYAPR03MB3573.namprd03.prod.outlook.com (2603:10b6:a02:ae::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from xhacker.debian (124.74.246.114) by TY1PR01CA0205.jpnprd01.prod.outlook.com (2603:1096:403::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Thu, 23 Apr 2020 06:38:01 +0000 X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) X-Originating-IP: [124.74.246.114] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 43105689-325f-43b9-3133-08d7e750df2c X-MS-TrafficTypeDiagnostic: BYAPR03MB3591: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:459; X-Forefront-PRVS: 03827AF76E X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR03MB3573.namprd03.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(376002)(39860400002)(136003)(366004)(396003)(346002)(6666004)(7696005)(26005)(66476007)(316002)(66946007)(66556008)(1076003)(52116002)(5660300002)(956004)(6506007)(4744005)(16526019)(186003)(8936002)(81156014)(9686003)(8676002)(86362001)(2906002)(478600001)(55016002); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: synaptics.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FGvIlJzSi07KXX6BkBoPti5ajmWWZ8O95mRDxNpeeEz1EkwKdZlxb4Iiivi4YZKlDA6H5zlJi80eKpwanHMn6YnSaLZTG8RgEX/YaD6NHToXtzTOF9NhxcT1YX1nZB7bW+oDYRgL814wb+IDEzUByNNwXxhOPKN9KoWy+x+k+Ke4LHjErdXsuQZPS6uxQlYLYNnX8JQqEqsugO7vS2MS43gH5o63WyH5I3JG9zushiDGnO+SBGdjgmpu6Sz5h7te2vBeejWYAiI3XRY4fm0QzHqMBq+ByiFRhGx68Q0FZcqan9sk7v1GH2eNSDfChfl22WjdBeRuofBdWFClBeso6NZ/WjhjTT29PIKyYabkhj4lBJ+5u/cjjIqA76/BsVeO7BZTZzKClWg/yddARkmpXhPxo1Vj23Fgr2K+OEGpKLNw4vvhzs502ZO8FoyteLK+ X-MS-Exchange-AntiSpam-MessageData: BRiSPmiUVUgtYuA6Q8Nwr61ITXg8TAicps4FAbzyGkqzZejdvBcqOFZrdqRjaPI7B/iOdn05uuqW+ub8K0ULl/bU29GQ66Wr9w9fojuB99oNwTErNOdS3DNjgk8xXbJOxqiUY/pGnDTCPEFOA2+VQA== X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43105689-325f-43b9-3133-08d7e750df2c X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2020 06:38:02.6128 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DDaRvHAbpQktpcY0XJtv1XfG1wTwehUkeq0T0F8kknjvcbwC0rcJUvddNGJPu2wFsrbV5hHa1xp+L6HvGjR20Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3591 X-Spam_score: -2.1 X-Spam_score_int: -20 X-Spam_bar: -- X-Spam_report: Spam detection software, running on the system "stoneboat.default.lvansomeren.uk0.bigv.io", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: we go to this code path when (obj->hdr_chunk > 0), so there's no need to check if (obj->hdr_chunk > 0) again. Signed-off-by: Jisheng Zhang --- yaffs_guts.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) Content analysis details: (-2.1 points, 4.9 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [40.107.94.79 listed in list.dnswl.org] 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay -0.2 AWL AWL: Adjusted score from AWL reputation of From: address X-ACL-Warn: warn X-SA-Exim-Connect-IP: 40.107.94.79 X-SA-Exim-Mail-From: Jisheng.Zhang@synaptics.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on stoneboat.default.lvansomeren.uk0.bigv.io X-Spam-Level: X-Spam-Status: No, score=-2.1 required=4.9 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE autolearn=no autolearn_force=no version=3.4.2 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on stoneboat.default.lvansomeren.uk0.bigv.io) X-Mailman-Approved-At: Thu, 23 Apr 2020 09:16:48 +0100 Subject: [Yaffs] [PATCH] remove duplicated (obj->hdr_chunk > 0) check X-BeenThere: yaffs@stoneboat.aleph1.co.uk X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion of YAFFS NAND flash filesystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2020 06:38:12 -0000 we go to this code path when (obj->hdr_chunk > 0), so there's no need to check if (obj->hdr_chunk > 0) again. Signed-off-by: Jisheng Zhang --- yaffs_guts.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/yaffs_guts.c b/yaffs_guts.c index 40a5b46..9845c46 100644 --- a/yaffs_guts.c +++ b/yaffs_guts.c @@ -4532,13 +4532,11 @@ int yaffs_get_obj_name(struct yaffs_obj *obj, YCHAR *name, int buffer_size) memset(buffer, 0, obj->my_dev->data_bytes_per_chunk); - if (obj->hdr_chunk > 0) { - result = yaffs_rd_chunk_tags_nand(obj->my_dev, + result = yaffs_rd_chunk_tags_nand(obj->my_dev, obj->hdr_chunk, buffer, NULL); - if (result == YAFFS_OK) - yaffs_load_name_from_oh(obj->my_dev, name, + if (result == YAFFS_OK) + yaffs_load_name_from_oh(obj->my_dev, name, oh->name, buffer_size); - } yaffs_release_temp_buffer(obj->my_dev, buffer); } -- 2.7.4